xgoGetProperties.Result is non-nullable (XGoProperty[]), but other xgo.* executeCommand results in this module are modeled as nullable (e.g., xgoRenameResources.Result, xgoGetInputSlots.Result). Since LSP workspace/executeCommand can legitimately return null, consider making this XGoProperty[] | null (and handling null at call sites) to match the established pattern and avoid potential runtime null handling bugs.

For consistency with other commands like xgoGetInputSlots and to handle cases where the server might not find any properties or encounters an error, it's safer to allow null as a possible result. This prevents potential runtime errors if the server returns null and the client expects an array. Please also update the return type in SpxLSPClient.workspaceExecuteCommandXGoGetProperties accordingly.

Naming Inconsistency: The method name workspaceExecuteCommandXGoGetProperty (singular) doesn't match the command namespace xgoGetProperties (plural) or the command string 'xgo.getProperties'.

This breaks the established pattern in the codebase:

• xgoGetInputSlots → workspaceExecuteCommandXGoGetInputSlots ✅
• xgoRenameResources → workspaceExecuteCommandXGoRenameResources ✅
• xgoGetProperties → workspaceExecuteCommandXGoGetProperty ❌

Recommendation: Rename to workspaceExecuteCommandXGoGetProperties (plural) for consistency.

Type Safety Issue: The Result type should include | null for consistency with other LSP commands.

Current: export type Result = XGoProperty[]
Compare with:

• xgoGetInputSlots.Result = XGoInputSlot[] | null (line 31)
• xgoRenameResources.Result = lsp.WorkspaceEdit | null (line 10)

Recommendation: Change to export type Result = XGoProperty[] | null to ensure proper type safety if the LSP server returns null.

Missing Convenience Method: Consider adding a higher-level getProperties wrapper method following the established pattern in this codebase.

Existing patterns:

• getInputSlots (line 428) wraps workspaceExecuteCommandXGoGetInputSlots
• getCompletionItems (line 421) wraps textDocumentCompletion
• getResourceReferences (line 389) wraps textDocumentDocumentLink

Suggested implementation:

async getProperties(ctx: RequestContext, target: string): Promise<xgoGetProperties.XGoProperty[]> {
  const result = await this.workspaceExecuteCommandXGoGetProperties(ctx, { target })
  if (result == null) return []
  return result
}

This would provide a cleaner API and improve maintainability.

Input Validation: The target parameter lacks validation. Consider adding constraints to ensure it conforms to expected patterns (identifier rules or "Game" literal).

Security consideration: While the LSP runs in a sandboxed Web Worker, adding validation provides defense in depth if the WASM language server has vulnerabilities in string handling.

Recommendation:

• Document the expected format and constraints explicitly
• Consider runtime validation for identifiers
• Add examples of valid vs invalid target values in the JSDoc

Documentation Enhancement: Consider adding more detailed JSDoc for the type field:

• What format does the type string use? (Go type syntax? Simplified names?)
• Examples of common type values (e.g., "int", "string", "func()", etc.)

This would help developers understand what to expect from the API response.